Replaced emulator-player mode hot patches with updates to menu.py #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stand-alone emulator previously used the same menu.py file that runs on the device, but manipulated the python code with some hot patches to be able to dynamically load all the games from the Arcade.
This change avoids this hot patching by making some minimal fallback behaviour in menu.py:
/Games/
, menu.py will load the list of games from a `/Games' file, which is provided by the standalone emulator.stat
on the game file errors, assume we are running in emulatton mode and ignore it.HEYTHUMBY!LOAD:TinyBlocks
There is also a related change in play.js that cleans up better when games end and it goes back to the menu. Previously, lots of hidden Editor widgets would be left open.
There should be no other behavioural changes with this update expect code that is less brittle to future changes.
Tests on the the following looked good to me: