Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated TinyColor.fromRGB() w/ readme update #40

Merged
merged 4 commits into from Mar 20, 2022
Merged

Deprecated TinyColor.fromRGB() w/ readme update #40

merged 4 commits into from Mar 20, 2022

Conversation

calvintam236
Copy link
Member

TinyColor.fromRGB() usage is same as TinyColor(Color.fromARGB()).

@calvintam236 calvintam236 added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 7, 2022
@calvintam236 calvintam236 requested a review from WieFel March 7, 2022 00:32
@calvintam236
Copy link
Member Author

We should either:

  • deprecated TinyColor.fromRGB()
  • TinyColor constructors replace Color one by adding TinyColor.fromARGB() and TinyColor.fromRGBO()

@calvintam236
Copy link
Member Author

We should either:

  • deprecated TinyColor.fromRGB()
  • TinyColor constructors replace Color one by adding TinyColor.fromARGB() and TinyColor.fromRGBO()

@WieFel any thoughts on this? i believe it is better just to take the first approach as #41 will make the other constructors to be .fromXXX() (XXX as dart/flutter existing class).

@WieFel
Copy link
Member

WieFel commented Mar 9, 2022

@calvintam236 yes ok, go with the first approach ;)

@calvintam236
Copy link
Member Author

@calvintam236 yes ok, go with the first approach ;)

@WieFel can you approve this?

WieFel
WieFel requested changes Mar 9, 2022
View reviewed changes
lib/src/tinycolor.dart Show resolved Hide resolved
@calvintam236 calvintam236 added this to the v2.1.0 milestone Mar 9, 2022
WieFel
WieFel previously approved these changes Mar 9, 2022
View reviewed changes
@calvintam236 calvintam236 merged commit a481e65 into master Mar 20, 2022
@calvintam236 calvintam236 deleted the feature/deprecated-constructors branch March 20, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WieFel WieFel WieFel approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@calvintam236 @WieFel