Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .greyscale() should be a method, not a property in Color extension #45

Merged
merged 4 commits into from Mar 9, 2022

Conversation

calvintam236
Copy link
Member

Since .greyscale() is a shorthand of another method, and it is not a property, the extension should be .greyscale() instead of .greyscale.

@calvintam236 calvintam236 added the bug Something isn't working label Mar 8, 2022
@calvintam236 calvintam236 added this to the v2.0.1 milestone Mar 8, 2022
@calvintam236 calvintam236 requested a review from WieFel March 8, 2022 07:35
@calvintam236 calvintam236 added this to Needs triage in Bugs via automation Mar 8, 2022
@calvintam236 calvintam236 added the documentation Improvements or additions to documentation label Mar 8, 2022
@calvintam236 calvintam236 moved this from Needs triage to Low priority in Bugs Mar 8, 2022
WieFel
WieFel previously approved these changes Mar 9, 2022
@calvintam236
Copy link
Member Author

@WieFel can you approve again after merging this changelog conflict?

@calvintam236 calvintam236 merged commit c3b49c6 into master Mar 9, 2022
Bugs automation moved this from Low priority to Closed Mar 9, 2022
@calvintam236 calvintam236 deleted the hotfix/greyscale branch March 9, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Bugs
Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants