Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xschem-viewer vscode version #7

Closed
barakhoffer opened this issue Apr 15, 2024 · 13 comments
Closed

xschem-viewer vscode version #7

barakhoffer opened this issue Apr 15, 2024 · 13 comments

Comments

@barakhoffer
Copy link

I think it would be cool to do a vscode extension xschem-viewer version, where you can use vscode preview to quickly move and browse schematics.
I can also take part in the development.

@urish
Copy link
Member

urish commented Apr 15, 2024

Indeed! Would love if you took part in the development

@barakhoffer
Copy link
Author

I created a very simple POC for this, see here:
vscode-xschem-viewer

@urish
Copy link
Member

urish commented Apr 28, 2024

Cool!

Do you plan to publish it to the VS Code marketplace?

@barakhoffer
Copy link
Author

Yes I will publish it 😄
Do you have any rejections/comments?
Thanks

@urish
Copy link
Member

urish commented Apr 30, 2024

Thanks!

Overall it looks good. A few things I noticed:

  1. When opening a file, the initial zoom level is off. Not sure if it's due to the extension or xschem-viewer itself:

image

  1. Would be nice to also open .sym files (right now, it only deals with .sch files)

  2. Marketplace listing:

image

Icon is missing, and Tiny Tapeout should be written this way. We'd appreciate a shout out to Tiny Tapeout in the README, something along the lines of:

Tiny Tapeout is an educational project that aims to make it easier and cheaper than ever to get your digital and analog designs manufactured on a real chip.

To learn more and get started, visit https://tinytapeout.com/.

Not mandatory, but will definitely make us happy to see it.

@barakhoffer
Copy link
Author

Thanks for the comments!
The zoom level seems to be xschem-viewer itself, do you have a zoom-to-fit function or something like that?
Also, can I use the Tiny Tapeout icon for the vscode marketplace?

@urish
Copy link
Member

urish commented May 6, 2024

The zoom level seems to be xschem-viewer itself, do you have a zoom-to-fit function or something like that?

Yes, not sure why it's not working correctly though:

panzoomInstance.showRectangle(new DOMRect(0, 0, bbox.width, bbox.height));

Also, can I use the Tiny Tapeout icon for the vscode marketplace?

You mean here?

image

Or somewhere else?

@barakhoffer
Copy link
Author

yes, the icon as you marked

@urish
Copy link
Member

urish commented May 6, 2024

In that case, IMHO it makes sense to use Xschem icon - @StefanSchippers are you good with it?

@StefanSchippers
Copy link

@urish no problem. Use the icon / image / logo you like more and think it's best for the purpose.

@barakhoffer
Copy link
Author

done :)
vscode-xschem-viewer

@urish
Copy link
Member

urish commented May 6, 2024

Great, TYSM!

One more suggestion: include a screen shot in the README

@curtisma
Copy link

curtisma commented May 10, 2024

Awesome, exactly what I need! 💯
Thanks for the great work @barakhoffer, @urish, and @StefanSchippers!

I've been thinking about the need for this over the last month or two. I even presented the idea at a conference panel last month and all the panelists agree that a vscode xschem schematic editor would be awesome. It was the "Will open source design be the future direction?" panel at the IEEE CICC conference in Denver on April 24th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants