Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build is broken #297

Open
kazimuth opened this issue Sep 5, 2019 · 13 comments
Open

CI build is broken #297

kazimuth opened this issue Sep 5, 2019 · 13 comments

Comments

@kazimuth
Copy link

kazimuth commented Sep 5, 2019

The CI build is failing. It seems to have something to do with halide's ABI not matching LLVM's, not sure how to fix that.

@rbaghdadi
Copy link
Collaborator

rbaghdadi commented Sep 5, 2019

Hi @kazimuth , yes indeed. If we use the new Halide (and not our fork of Halide which is a bit old), that would solve the problem. On one of our internal machines, Tiramisu works fine with a new Halide, but I just did not have time to propagate the change to CI.

If you are interested in helping on that I can give you assistance and we can try.

@kazimuth
Copy link
Author

kazimuth commented Sep 5, 2019

I might be able to pick that up, sure. I'm contemplating using Tiramisu for some MIT coursework this semester, but to do that I'll need a functioning build on my machine :)

@rbaghdadi
Copy link
Collaborator

Oh Ok I see. That one is independent though. You should be able to compile and use Tiramisu without a problem. The problem that we have with CI is only related to a mismatch in the LLVM versions we are using or something. There is a PR that tries to address that, but I still didn't have time to test it.

Go ahead and just install Tiramisu on your machine and let us know if you have a problem. If you get a problem I'll be happy to help you out.

@kazimuth
Copy link
Author

kazimuth commented Sep 5, 2019

Yeah, I was running into the same problem cause I was trying to avoid recompiling LLVM lol.

Will do.

@rbaghdadi
Copy link
Collaborator

Ok, here is the solution then:

  • Compile a fresh Halide as described in the Halide github page: https://github.com/halide/Halide (you do not need to compiler LLVM from sources)
  • Then use that Halide to compile Tiramisu. You need only to edit the two lines here:
    set(HALIDE_SOURCE_DIRECTORY "3rdParty/Halide")

    to point to your new Halide.

In principle, if you get a fresh Halide from the halide repo, that one is good. The Halide that we have is a bit old and does not have the fix to avoid the problem you specified.

@rbaghdadi
Copy link
Collaborator

Let me know if this works for you.

@kazimuth
Copy link
Author

kazimuth commented Sep 5, 2019

Compiling old LLVM and halide works fine.

Using current halide gives a few compile errors; they seem fixable, though. I might take a shot at patching them over the weekend.

@rbaghdadi
Copy link
Collaborator

Ok this is perfect! So if I understood well, you problem is solved now?

You want to patch the old Halide or the new one?

@kazimuth
Copy link
Author

kazimuth commented Sep 5, 2019

I think it would be possible to just patch tiramisu to use the new halide. Most of the changes seem to be small changes to function signatures, unless there have been any major underlying architecture changes in Halide I'm not seeing.

@rbaghdadi
Copy link
Collaborator

In theory, even Tiramisu should not be modified. It should work with the new Halide without a change. Only the github submodule pointer has to point to the public halide instead of pointing to the current outdated Halide. I have tried before to make it work with the new Halide and it just worked with the need to change Tiramisu so it should be fine! (unless I'm missing something)

@kazimuth
Copy link
Author

kazimuth commented Sep 8, 2019

Hm, there seem to be some compilation errors? Changed signatures and stuff, with the most recent halide release.

@rbaghdadi
Copy link
Collaborator

rbaghdadi commented Sep 8, 2019 via email

@mratsim
Copy link
Contributor

mratsim commented Sep 23, 2019

Are there new errors compared to those I reported? #217 (note that I didn't try to build Tiramisu with Halide master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants