added default virtual dtor to 'computation' and missing return … #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…object to 'auto_scheduler::create_initial_computation_graph'
ct-clmsn
changed the title
|
build error is related to an llvm versioning issue? there's an undefined reference in the halide portion of the compilation. |
…t from 'function' this improves the extensibility of the code generator to new languages
|
added a modification to where 'protected' is declared over methods in 'class function'. the methods that are now declared protected enable the 'function' class to be extensible. making the class 'function' extensible makes tiramisu capable of supporting new languages (ie: physl). |
…ues to resolve in the future
…ation that are not defined this causes linking errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-8 identifies two compilation issues. the first is a missing virtual dtor in
computation, the second is a missing return value inauto_scheduler::create_initial_computation_graph.