Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added get_my_about() #72

Merged
merged 6 commits into from
Oct 31, 2020
Merged

added get_my_about() #72

merged 6 commits into from
Oct 31, 2020

Conversation

beatorizu
Copy link
Contributor

Resolves #68

@NavpreetDevpuri
Copy link
Member

@beatorizu check that I just created

tithiwa/tithiwa/waobject.py

Lines 152 to 153 in 1f29ec9

def _press_back_button(self):
self._wait_for_an_element_to_be_clickable(SELECTORS.BACK_BUTTON).click()

@NavpreetDevpuri
Copy link
Member

And I noticed both names and about are having the same HTML structure
chrome_4jkKtA2arj

if we use selector '._2FVVk._3WjMU' it will end up getting two elements

ShareX_PBFDYNNnyj

So, it's better to use the following method to get a list of elements

tithiwa/tithiwa/waobject.py

Line 51 in 01e9d30

def _wait_for_presence_of_all_elements(self, selector):

@NavpreetDevpuri NavpreetDevpuri changed the title Show profile added get_my_about() Oct 31, 2020
@NavpreetDevpuri NavpreetDevpuri merged commit e7c6168 into Tithibots:main Oct 31, 2020
@NavpreetDevpuri NavpreetDevpuri added this to In progress in Automate essentials via automation Oct 31, 2020
@NavpreetDevpuri NavpreetDevpuri removed this from In progress in Automate essentials Oct 31, 2020
NavpreetDevpuri added a commit that referenced this pull request Oct 31, 2020
@NavpreetDevpuri
updated
1f51d1e 
#72

#71
NavpreetDevpuri added a commit that referenced this pull request Oct 31, 2020
@NavpreetDevpuri
added _wait_until_innerText_is_empty_of_an_element()
9b30a9d 
#72

#71
@beatorizu
Copy link
Contributor Author

@NavpreetDevpuri could you add the hacktoberfest-accepted label?

@beatorizu beatorizu deleted the get-my-about branch December 28, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create get_my_about() in waobject.py
2 participants
@beatorizu @NavpreetDevpuri