Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear_all_chats method was added in Tithiwa class #83

Merged
merged 10 commits into from
Oct 30, 2021

Conversation

ghostrider22
Copy link
Contributor

Capture
Since whatsapp had two elements for menu with same class and Ids, I was forced to use full xpath instead of CSS selector for accessing the menu. Then using arrow keys the program navigates to "clear messages", and then uses ENTER key to clear chat.
Sometimes chat takes some time to load, and program returned error "element not found", to avoid that I tried using implicit wait - self.browser.implicitly_wait(3), but for some reason I still recieved error so atlast I used sleep(0.5).

@NavpreetDevpuri NavpreetDevpuri linked an issue Oct 26, 2021 that may be closed by this pull request
@NavpreetDevpuri
Copy link
Member

NavpreetDevpuri commented Oct 26, 2021

We need to avoid using sleep() because we need to find an efficient way so that we don't need to wait longer. i.e use efficient one of something is done or something is not done

And we need to fix #84

Give it a try

@ghostrider22
Copy link
Contributor Author

Ok sir

@ghostrider22
Copy link
Contributor Author

Sir, I have removed time.sleep() and instead added try-except block inside a infinite while loop. The only way to break while loop is when the program successfully finds and clicks the desired element. I have tested the program and its working fine.

@NavpreetDevpuri
Copy link
Member

We found new bug #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants