Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build system and add f/b keys #26

Merged
merged 3 commits into from
Sep 28, 2020
Merged

Conversation

esmil
Copy link
Contributor

@esmil esmil commented Sep 20, 2020

Hi, nice little tool!

I've updated the Makefile so it should hopefully be a little more flexible for distro maintainers to use pkg-config and overwrite variables with make VAR=whatever.

I've tested it with and without pkg-config on buster, sid, focal, rawhide and Archlinux, but unfortunately I don't have access to a Mac so please test that before merging. Plain make should work exactly as before though.

..and other updates to make it easier for distro packagers.

Also put all build artifacts into build directory.
This is not strictly standard C, but is supported by
both GCC and Clang.
@Titor8115
Copy link
Owner

@esmil HEY!!! I so glade someone with more distro makefile experience finally appeared! I'll test it out on the Mac tomorrow.

PS: I didn't use __has_include because overthinking constantly about backward compatibility. (silly me...)

@esmil
Copy link
Contributor Author

esmil commented Sep 24, 2020

Don't worry. Worrying about using __has_include is not necessarily silly. It just depends on how valuable you think it is that mandown works on old and/or weird systems that doesn't use either gcc or clang.

@Titor8115 Titor8115 merged commit 81710e9 into Titor8115:master Sep 28, 2020
@Titor8115
Copy link
Owner

Titor8115 commented Oct 8, 2020

@esmil I did another test after realizing I set my mac's terminal to automatically connect to my VM Linux. It seems there an issue when running line 124 -include $O/*.d $O/*/*.d or line 132 $O/%/:

The error message is make: *** build/*.d: Is a directory. Stop.
I did some search about this error, and it seems to be an issue with OS X's case sensitivity when using directory as value in makefile. I'm not sure if you are familiar with this. I'm still trying to find a solution.

PS: makefile worked like a charm on other Linux distro.

@esmil
Copy link
Contributor Author

esmil commented Oct 9, 2020

Hmm.. interesting. Maybe try changing line 124 to

include $(wildcard $O/*.d $O/*/*.d)

and make line 132 more explicit with

$O/blender/ $O/parser/ $O/src/:

@Titor8115
Copy link
Owner

Yep, I think it was the line 124 that caused the problem. It's working now, I'm doing some additional test.
Thanks mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants