Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE][CPF-36] People page #32

Merged
merged 40 commits into from
Jul 16, 2024
Merged

[FE][CPF-36] People page #32

merged 40 commits into from
Jul 16, 2024

Conversation

PatrykIwasieczko
Copy link
Contributor

@PatrykIwasieczko PatrykIwasieczko commented Jun 11, 2024

Progress:
Screenshot 2024-06-12 at 14 36 56

#36

@PatrykIwasieczko PatrykIwasieczko force-pushed the 31-feature-people-page branch 3 times, most recently from 1f9c0ba to 6fc5690 Compare June 13, 2024 13:31
@jakubfolta jakubfolta self-assigned this Jun 18, 2024
@jakubfolta
Copy link
Contributor

The table was removed and replaced by CSS grid. Missing features are searchbar logic and pagination which I will be adding on next Monday.

@jakubfolta jakubfolta marked this pull request as ready for review July 10, 2024 16:50
@jakubfolta
Copy link
Contributor

#36

Hi guys, it's a huge PR. The most recent refactor regarding different API responses is done so when API will be ready you can just uncomment the code I left and it should be working fine.

Today I was working on pagination but I would need more time to finish it properly - if the amount of pages don't exceed the max pages from Figma which is 8 then all is working fine. I was trying to implement vanilla solution for these truncation buttons but didn't finish it. I left my code so you can check it.

If you have any questions feel free to reach me out as long as I am still available on Slack.
Take care guys, wish you all good 😄 ✌️

@r1skz3ro r1skz3ro changed the title feat: add people page [FE][CPF-31] People page Jul 16, 2024
@r1skz3ro r1skz3ro changed the title [FE][CPF-31] People page [FE][CPF-36] People page Jul 16, 2024
@skorekm skorekm merged commit 27e9bdf into develop Jul 16, 2024
4 checks passed
@skorekm skorekm deleted the 31-feature-people-page branch July 16, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants