Missing loads and load definitions in __init__.pyi

[hikariyo]

I know it is defined in __init__.py, but it seems that PyCharm only analyzes __init__.pyi, where loads is not defined.

Maybe I could create a PR to fix this tiny problem if you appreciate it.

[hikariyo]

The same as load function.

[lemire]

@kifuan Would you prepare a pull request? I am sure it would be considered.

[hikariyo]

Sure, there are two ways.

1. Copy the declarations in __init__.py, like the code below:

def loads(s, *, cls=None, object_hook=None, parse_float=None, parse_int=None,
          parse_constant=None, object_pairs_hook=None, **kwargs):
  ...

2. Use json.load, json.loads.

loads = json.loads
load = json.load

As __init__.pyi is only an interface that will not be executed, it works properly.

[hikariyo]

But I prefer the first way, which will not confuse users.

[lemire]

Can't this be done automatically...

https://www.mypy-lang.org

[TkTech]

Can't this be done automatically...

https://www.mypy-lang.org

Automatic generation doesn't work terribly well with native extensions.

[TkTech]

Use json.load, json.loads.

We don't have a 1:1 interface with json.load/s, so this would result in incorrect signatures.

[hikariyo]

Is __init__.pyi generated or written manually? It doesn't look like a generated file.