Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose 1.5.0 beta, Kotlin 1.9.0, minor Coroutines and AndroidX Activity version #76

Merged
merged 10 commits into from
Jul 31, 2023

Conversation

TheronRogers
Copy link
Contributor

@TheronRogers TheronRogers commented Jul 27, 2023

Updated Libraries

This includes updates to the following:

Library From To
Kotlin 1.8.2 1.9.0
Coroutines 1.7.1 1.7.3
Compose 1.4.2 1.5.0-beta03
Jetbrains Compose 1.4.0 1.5.0-dev1122
AndroidX Activity 1.7.0 1.7.2

Changes

AnimatedContentScope was converted to an Interface so now we need to use AnimatedContentTransitionScope

EnterTransition with is deprecated and replaced by togetherWith

ComposeUIViewController replaces Application on iOS and title string parameter is no longer used so removed.

Validations

I'm running this in a new project targeting Android, iOS & JVM. My project is running and navigating on each platform. Publish and test gradle commands succeed.

Note:
This is my first time submitting a PR to an OSS project. Please let me know how I can help.

TheronRogers and others added 8 commits July 25, 2023 21:06
Kotlin 1.8.20 -> 1.9.0
Jetpack Compose 1.4.2 -> 1.5.0-beta03
Jetbrains Compose 1.4.0 -> 1.5.0-dev1122

This required replacing `AnimatedContentScope` with `AnimatedContentTransitionScope` because `AnimatedContentScope` is now a sealed interface.

Also needed to swap deprecated `EnterTransition.with` calls for `EnterTransition.togetherWith`
This may affect window or app titles on iOS. I've left the unused title param for now.
Update Kotlin Coroutines version 1.7.2 -> 1.7.3
@sonatype-lift
Copy link

sonatype-lift bot commented Jul 27, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@Tlaster
Copy link
Owner

Tlaster commented Jul 27, 2023

Thanks for the PR!
The 1.5.x version of Compose breaks the build as the same as #74 , I'm trying to figure it out.

@TheronRogers
Copy link
Contributor Author

I didn't update usage of PreComposeApplication in the molecule sample to remove the title parameter. I'll get that in right now.

I also did not remove binaries.executable() as in this commit on #74. I don't have a Js target in my app so I'm not sure if that change is needed.

@TheronRogers
Copy link
Contributor Author

I'm going to disable signing and publishing and try to run the build action on my fork. I'll let you know if I can get it to pass.

@TheronRogers TheronRogers marked this pull request as draft July 28, 2023 19:50
@Tlaster Tlaster merged commit 65d74e7 into Tlaster:master Jul 31, 2023
1 of 2 checks passed
@Tlaster
Copy link
Owner

Tlaster commented Jul 31, 2023

I try to make it built in #78 and merged into master base on your pr, thanks for the pr, and I'll release a new version very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants