Port screentest from GTK+ 2 to 3 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuspg
force-pushed
the
markuspg/gtk_3
branch
4 times, most recently
from
9bc0c00
to
962c57c
Compare
This necessitates a bump of the minimum required GTK+ version to 3.4.
This fixes the regression of the test case `blink`.
markuspg
force-pushed
the
markuspg/gtk_3
branch
from
962c57c
to
202efa5
Compare
|
Really nice, thank you! |
|
BTW: Feel free to add yourself to whatever credits you like (AUTHORS file, the initial test page, etc.) |
|
You are welcome 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request conducts the minimum changes necessary to port screentest from GTK+ 2 to 3.
In summary the following changes are being conducted:
gtk+-2.0togtk+-3.0(at least in version3.4, which was released in 2012 and should be a sane baseline in 2024)exposeevent to thedrawhandler introduced by GTK+ 3GdkColorbyGdkRGBAGtkColorSelectionDialogbyGtkColorChooserDialoggtk_menu_popupbygtk_menu_popup_at_pointergdk_cairo_createandcairo_destroyinvocations