Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

feat: Support for PX4 flight modes #18

Merged
merged 3 commits into from Jun 15, 2016

Conversation

thedevleon
Copy link
Contributor

This adds support for PX4 flight modes (as requested by me in #13)
A little bit of refactoring also should allow for easier addition of other autopilots in the future.

Tested on a PixHawk running latest PX4 and confirmed working.

This adds support for PX4 flight modes
and a little bit of refactoring allows for easier
addition of other autopilots
@TobiasBales
Copy link
Owner

TobiasBales commented Jun 15, 2016

3 things would be nice:
rename mav__component and mav__system to mav_component and mav_system
rename custom_mode to fc_mode maybe? because I think that is what it represents
and it seems your editor indented draw_flight_mode in src/osdproc.c with 4 spaces (could be tabs too. not sure), could you make that 2 spaces again? would be great

@thedevleon
Copy link
Contributor Author

Sure, I will rename mav_component and mav_system and fix the indentation.
I think though that custom_mode should stay custom_mode - since that's what it is named as in the mavlink specification and will make it easier for new developers to know what it represents.
Figuring out what osd_mode was initially was already quite confusing.

@TobiasBales
Copy link
Owner

the reasoning works for me

@TobiasBales TobiasBales merged commit 69998c1 into TobiasBales:master Jun 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants