Skip to content

Commit

Permalink
Fix: Support missing parents when constructing the deployability index (
Browse files Browse the repository at this point in the history
  • Loading branch information
izeigerman committed May 7, 2024
1 parent b926c92 commit 2f40390
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
2 changes: 1 addition & 1 deletion sqlmesh/core/snapshot/definition.py
Original file line number Diff line number Diff line change
Expand Up @@ -1211,7 +1211,7 @@ def _visit(node: SnapshotId, deployable: bool = True) -> None:
):
return

if deployable:
if deployable and node in snapshots:
snapshot = snapshots[node]
# Capture uncategorized snapshot which represents a forward-only model.
is_forward_only_model = (
Expand Down
14 changes: 14 additions & 0 deletions tests/core/test_snapshot.py
Original file line number Diff line number Diff line change
Expand Up @@ -1600,6 +1600,20 @@ def test_deployability_index_uncategorized_forward_only_model(make_snapshot):
assert not deplyability_index.is_representative(snapshot_b)


def test_deployability_index_missing_parent(make_snapshot):
snapshot_a = make_snapshot(SqlModel(name="a", query=parse_one("SELECT 1")))
snapshot_a.categorize_as(SnapshotChangeCategory.BREAKING)

snapshot_b = make_snapshot(SqlModel(name="b", query=parse_one("SELECT 1")))
snapshot_b.categorize_as(SnapshotChangeCategory.FORWARD_ONLY)
snapshot_b.parents = (snapshot_a.snapshot_id,)

deplyability_index = DeployabilityIndex.create({snapshot_b.snapshot_id: snapshot_b})

assert not deplyability_index.is_deployable(snapshot_b)
assert not deplyability_index.is_deployable(snapshot_a)


@pytest.mark.parametrize(
"model_name, environment_naming_info, default_catalog, expected",
(
Expand Down

0 comments on commit 2f40390

Please sign in to comment.