Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: escape backslashes in comments #2307

Merged
merged 2 commits into from Mar 20, 2024
Merged

Fix: escape backslashes in comments #2307

merged 2 commits into from Mar 20, 2024

Conversation

treysp
Copy link
Contributor

@treysp treysp commented Mar 19, 2024

  • Escape by default for all engines but Postgres
  • Do not escape when directly modifying a BigQuery table object to create column comments

Closes #2290

@treysp treysp requested a review from eakmanrq March 19, 2024 23:02
@treysp treysp merged commit bb7a864 into main Mar 20, 2024
10 checks passed
@treysp treysp deleted the trey/escape-backslashes branch March 20, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobymao tobymao tobymao approved these changes

@georgesittas georgesittas georgesittas approved these changes

@eakmanrq eakmanrq Awaiting requested review from eakmanrq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backslahes in comments should be escaped
3 participants
@treysp @tobymao @georgesittas