Add support for Python 3.10 #1049

akrherz · 2021-11-30T05:13:19Z

An attempt to bring Python 3.10 support to maint-1.8 branch? I paired back the original commit some out of my blissful ignorance of what may not be necessary. Please feel free to forcibly reject the PR with fire!

In my fork, the python3.6 build failure matches current maint-1.8 branch build failure

def test_write_memfile_crs_wkt():
E               AssertionError: assert 'SQLite' == 'GPKG'
E                 - SQLite
E                 + GPKG

To get python 3.10 green in CI, I needed to additionally:

add a setup.py shim since enum34 was not available.
bump pytest and boto3 to a version that works on python 3.10

The please-with-a-cherry-on-top, would be to then cut a 1.8.21 release :)

mwtoews · 2021-11-30T07:49:42Z

See #1037 for test_write_memfile_crs_wkt; I've just pushed that here to see if that clears the status...

mwtoews

Looks great, and I'd like to see a release soon too!

sgillies · 2021-12-08T04:41:11Z

Me, too! We don't have wheel-building infrastructure right now and it'll take a few days to set it up. On top of that, I'm not really sure how much it will cost to build the wheels on Travis now since the support for open source projects is gone. $.01? $10? I didn't get any insight into that when I was building the wheels from the Mapbox account.

fiona/drvsupport.py

sgillies · 2021-12-08T04:45:32Z

setup.py

@@ -295,6 +295,9 @@ def run(self):
    'ordereddict; python_version < "2.7"',
    'enum34; python_version < "3.4"'
 ]
+# Python 3.10 workaround as enum34 not available
+if sys.version_info >= (3, 10):
+    requirements.remove('enum34; python_version < "3.4"')


This shouldn't be needed. The intent of enum34; python_version < "3.4" is that enum34 only gets installed for python versions lower than 3.4.

I hit a bug without this and how python=3.10 gets compared to python 3.4 -> (python 3.10 < python 3.4) evaluated to true :)

Oof. I dug and found that this bug was fixed 2 years ago: pypa/pip#7166. What version of pip are you using?

I wasn't doing anything, it was whatever CI here is using :)

sgillies · 2021-12-08T04:46:10Z

tests/test_open.py

@@ -21,6 +23,7 @@ def test_open_filename_with_exclamation(data_dir):
    assert fiona.open(path), "Failed to open !test.geojson"


+@requires_gdal21


Tests were passing without this before, no?

shrug, maybe

Oh, this change is something @mwtoews added to make things greeen, sorry, I forgot what I did here :)

This is from #1037

sgillies

@akrherz Thanks! I have some questions inline.

rbuffat · 2021-12-11T22:33:43Z

Me, too! We don't have wheel-building infrastructure right now and it'll take a few days to set it up. On top of that, I'm not really sure how much it will cost to build the wheels on Travis now since the support for open source projects is gone. $.01? $10? I didn't get any insight into that when I was building the wheels from the Mapbox account.

@sgillies A solution to this would be to build wheels locally. In https://github.com/rbuffat/manylinux_gdal I extended the pypa/manylinux_2_24_x86_64 Docker image with precompiled versions of gdal (inspired from fiona-wheels). With the commands outlined in https://github.com/rbuffat/manylinux_gdal/blob/main/Readme.md it is possible to build wheels locally using Docker. Though, I have not yet tested if they actually work. Probably it will require some more work in order to get it working properly. If you are interested, please contact me so that we can coordinate.

dopplershift · 2022-01-29T01:12:16Z

@sgillies It would be really nice to get a fiona that works on 3.10. As far as wheel-building goes, is there anything special you're using Travis for (e.g. powerpc, arm)? Otherwise a lot of the community has moved to Azure and GitHub actions. I'd be happy to lend my expertise on the GitHub Actions side if there's hope of the work getting merged. Currently, this is keeping me from building docs on 3.10 on some of my projects.

sgillies · 2022-01-30T23:12:51Z

@dopplershift thanks for letting me know! I had assumed that you and your users were getting everything you needed from conda-forge.

Two weeks ago I finished migrating rasterio's wheel infra to GitHub Actions: https://github.com/rasterio/rasterio-wheels. If you've got time, this multibuild configuration could be copied over to a PR against https://github.com/sgillies/fiona-wheels.

sgillies · 2022-01-30T23:19:01Z

Apologies for the slowness, everyone! Merging.

mwtoews and others added 4 commits November 29, 2021 21:45

Add support for Python 3.10 (Toblerity#1046)

1d4230a

workaround python3.10 + enum34 issue

664ce72

bump pytest to support python 3.10

646eb60

bump boto3 version to support python3.10

b8d25de

akrherz mentioned this pull request Nov 30, 2021

Rebuild for python 3.10 conda-forge/fiona-feedstock#188

Merged

4 tasks

TST: require GDAL>=2.1 for test_open.py::test_write_memfile_crs_wkt

695ae4b

mwtoews approved these changes Nov 30, 2021

View reviewed changes

mwtoews changed the title ~~Add support for Python 3.10 (#1046)~~ Add support for Python 3.10 Nov 30, 2021

mwtoews added this to the 1.8.21 milestone Nov 30, 2021

EwoutH mentioned this pull request Dec 2, 2021

CI: Add Python 3.10 to job matrix geopandas/geopandas#2205

Merged

sgillies reviewed Dec 8, 2021

View reviewed changes

fiona/drvsupport.py Show resolved Hide resolved

sgillies reviewed Dec 8, 2021

View reviewed changes

weiji14 mentioned this pull request Dec 20, 2021

Use Python 3.10 in Continuous Integration tests GenericMappingTools/pygmt#1577

Merged

5 tasks

scottyhq mentioned this pull request Dec 22, 2021

Unpinned tests fail for workflow SlideRuleEarth/sliderule-python#65

Closed

sgillies mentioned this pull request Dec 23, 2021

1.9.0 Release #1053

Closed

martinfleis mentioned this pull request Jan 15, 2022

Unable to install built wheels with Python 3.10 geopandas/geopandas#2212

Closed

dopplershift mentioned this pull request Jan 29, 2022

Drop Python 3.7 Unidata/MetPy#2317

Merged

2 tasks

sgillies merged commit b442840 into Toblerity:maint-1.8 Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Python 3.10 #1049

Add support for Python 3.10 #1049

akrherz commented Nov 30, 2021

mwtoews commented Nov 30, 2021

mwtoews left a comment

sgillies commented Dec 8, 2021

sgillies Dec 8, 2021

akrherz Dec 8, 2021 •

edited

sgillies Dec 8, 2021

akrherz Dec 8, 2021

sgillies Dec 8, 2021

akrherz Dec 8, 2021

akrherz Dec 8, 2021

mwtoews Dec 9, 2021

sgillies left a comment

rbuffat commented Dec 11, 2021 •

edited

dopplershift commented Jan 29, 2022

sgillies commented Jan 30, 2022

sgillies commented Jan 30, 2022

		@@ -21,6 +23,7 @@ def test_open_filename_with_exclamation(data_dir):
		assert fiona.open(path), "Failed to open !test.geojson"


		@requires_gdal21

Add support for Python 3.10 #1049

Add support for Python 3.10 #1049

Conversation

akrherz commented Nov 30, 2021

mwtoews commented Nov 30, 2021

mwtoews left a comment

Choose a reason for hiding this comment

sgillies commented Dec 8, 2021

sgillies Dec 8, 2021

Choose a reason for hiding this comment

akrherz Dec 8, 2021 • edited

Choose a reason for hiding this comment

sgillies Dec 8, 2021

Choose a reason for hiding this comment

akrherz Dec 8, 2021

Choose a reason for hiding this comment

sgillies Dec 8, 2021

Choose a reason for hiding this comment

akrherz Dec 8, 2021

Choose a reason for hiding this comment

akrherz Dec 8, 2021

Choose a reason for hiding this comment

mwtoews Dec 9, 2021

Choose a reason for hiding this comment

sgillies left a comment

Choose a reason for hiding this comment

rbuffat commented Dec 11, 2021 • edited

dopplershift commented Jan 29, 2022

sgillies commented Jan 30, 2022

sgillies commented Jan 30, 2022

akrherz Dec 8, 2021 •

edited

rbuffat commented Dec 11, 2021 •

edited