Establish minimum Python version 3.6 for maint-1.9 branch #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwtoews
force-pushed
the
maint-1.9-minimum-python-3.6
branch
from
8f3cb79
to
9b6741b
Compare
|
Any glaring issues here @sgillies ? I might merge this sooner than later before it gets stale. |
|
I'm going to remove 3.6 from the classifiers in setup.py. 3.7 will be the minimum Python version and we may yet increase to 3.8 before 1.9.0 as Python 3.11 is close. |
|
@sgillies are you doing this? Otherwise, I can increase it to Python 3.8. There are other simple upgrades for Python 3.7 that I can see that I could slip in. Update: never-mind, I see the relevant commits now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the minimum Python version to 3.6 for the maint-1.9 branch, for the upcoming Fiona 1.9.x release series.
It is mainly based on a few cherry picks from:
A few manual edits were required. It should have minimal conflicts with
master. Compatibility with the Fiona 1.8.x series should be maintained.