Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring onboard filter, map, and reduce from fio-planet #1362

Merged
merged 7 commits into from
Apr 3, 2024
Merged

Conversation

sgillies
Copy link
Member

@sgillies sgillies commented Mar 18, 2024

With some refactoring and conditional enablement of commands that require shapely.

TODO:

  • deprecation of old style filter expressions
  • docs

Resolves #1327

With some refactoring and conditional enablement of commands that
require shapely.
@sgillies sgillies added this to the 1.10 milestone Mar 18, 2024
@sgillies sgillies self-assigned this Mar 18, 2024
@sgillies
Copy link
Member Author

@mwtoews do you have any comments on the new documentation? I think it looks okay and that this PR is ready for a final review. I feel good about allowing the new and old filter expressions to live side-by-side for a while.

https://fiona--1362.org.readthedocs.build/en/1362/cli.html#filter
https://fiona--1362.org.readthedocs.build/en/1362/cli.html#expressions-and-functions
https://fiona--1362.org.readthedocs.build/en/1362/cli.html#sizing-up-and-simplifying-shapes

@sgillies
Copy link
Member Author

sgillies commented Apr 1, 2024

@snorfalorpagus @perrygeo any objections to this?

Copy link
Collaborator

@perrygeo perrygeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snuggs for vector data! Looks good and provides a better DSL than the old python expressions. I'm curious too see how far people can push this... writing an entire analysis pipeline with snuggs seems feasible.

Some Lisp programmers might have a heart attack at the optional outer parens but I think it makes the CLI easier on the eyes. +1

I'm not 100% clear on the logic for differentiating the type of expression. I'm imagining a case where the syntax is ambiguous and a previously valid python expression gets misinterpreted as a snuggs expression. I don't have a good example though, probably not an issue.

Looks great!

@sgillies sgillies merged commit 63f99ce into main Apr 3, 2024
10 checks passed
@sgillies sgillies deleted the issue1327 branch April 3, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add commands from fio-planet
3 participants