Silence NumPy 1.21 DeprecationWarning by raising AttributeError #1174
Conversation
| def test_numpy_empty_linearring_coords(): | ||
| np = pytest.importorskip("numpy") | ||
|
|
||
| ring = LinearRing() | ||
| assert np.asarray(ring.coords).shape == (0,) | ||
|
|
||
|
|
||
| @pytest.mark.filterwarnings("error:An exception was ignored") # NumPy 1.21 |
There was a problem hiding this comment.
This is the only test that didn't need @shapely20_deprecated to silence "ShapelyDeprecationWarning: The array interface is deprecated...", and I have no idea why. @jorisvandenbossche ?
There was a problem hiding this comment.
So I think this is because Polygon already didn't have an array interface before (its rings have one), so for polygon the array interface didn't need to be deprecated. In addition, it also doesn't have deprecation of __len__ or iteration like the multi-part geometries (that also didn't work before), where those warnings are also typically raises when interacting with numpy.
|
@sgillies I'm keen to see this in the next pre-release |
|
@mwtoews sorry for the slow response here. I'll try to take a look tomorrow |
There was a problem hiding this comment.
Thanks, looks good! Changing the error we raise is indeed the good solution for 1.8
I added a small change: I added a similar test for GeometryCollection (it should also work for that type, and the test passes), and also added an assert that the geometry stored in the array is correct (that it's eg not unpacked).
| @@ -87,6 +87,7 @@ def test_from_numpy(): | |||
| assert line.coords[:] == [(1.0, 2.0), (3.0, 4.0)] | |||
|
|
|||
|
|
|||
| @pytest.mark.filterwarnings("error:An exception was ignored") # NumPy 1.21 | |||
| def test_numpy_empty_linestring_coords(): | |||
There was a problem hiding this comment.
This case shouldn't raise a warning? (it's directly accessing the array interface of .coords, which should work fine, also for an empty geometry giving an empty array)
There was a problem hiding this comment.
Whoops, sorry, missed the "error" :) (I thought it was ignoring those warnings)
| def test_numpy_empty_linearring_coords(): | ||
| np = pytest.importorskip("numpy") | ||
|
|
||
| ring = LinearRing() | ||
| assert np.asarray(ring.coords).shape == (0,) | ||
|
|
||
|
|
||
| @pytest.mark.filterwarnings("error:An exception was ignored") # NumPy 1.21 |
There was a problem hiding this comment.
So I think this is because Polygon already didn't have an array interface before (its rings have one), so for polygon the array interface didn't need to be deprecated. In addition, it also doesn't have deprecation of __len__ or iteration like the multi-part geometries (that also didn't work before), where those warnings are also typically raises when interacting with numpy.
|
Thanks for the additions @jorisvandenbossche ! And also nice to see you work on a general solution for geopandas too. |
Possible fix for NumPy 1.21 DeprecationWarning for exceptions raised in
__array_interface__. OnlyBaseGeometry.__array_interface__still raise NotImplementedError, as it is an abstract class.Tests for each geometry type (except GeometryCollection) are added, which creates/assigns an object array.
Comments/reviews are welcome!
Closes #1173