Use CompilingMatcher in DefaultPolicy for performance reasons

Toflar · Sep 13, 2023 · f3aafb9 · f3aafb9
1 parent 5474dc9
commit f3aafb9
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/Composer/DependencyResolver/DefaultPolicy.php b/src/Composer/DependencyResolver/DefaultPolicy.php
@@ -15,6 +15,7 @@
 use Composer\Package\AliasPackage;
 use Composer\Package\BasePackage;
 use Composer\Package\PackageInterface;
+use Composer\Semver\CompilingMatcher;
 use Composer\Semver\Constraint\Constraint;
 
 /**
@@ -49,10 +50,12 @@ public function versionCompare(PackageInterface $a, PackageInterface $b, string
             return BasePackage::$stabilities[$stabA] < BasePackage::$stabilities[$stabB];
         }
 
-        $constraint = new Constraint($operator, $b->getVersion());
-        $version = new Constraint('==', $a->getVersion());
+        // TODO: Why is this not the case in CompilingMatcher?
+        if (false !== strpos($a->getVersion(), 'dev-') || false !== strpos($b->getVersion(), 'dev-')) {
+            return true;
+        }
 
-        return $constraint->matchSpecific($version, true);
+        return CompilingMatcher::match(new Constraint($operator, $b->getVersion()), Constraint::OP_EQ, $a->getVersion());
     }
 
     /**