-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Windows #1
Conversation
I guess we should integrate this also into our tests and run those on windows only (and the current ones on linux only). I've just pushed the foundation for Github tests to |
Hm, right now I can't come up with a way to adjust |
I mean the test would work, if you run it in a cygwin or mingw command line under Windows - is that something you can set up? Then this could be merged as is. |
My goal would be to add another job in the workflows with |
No, Symfony Process starts every process via |
Maybe in conjunction with https://github.com/marketplace/actions/install-cygwin then? I'm not familiar with it at all so I don't think I can set this up^^ |
Besides, the |
Me neither, but we can try ;) |
This PR adds support for Windows by using
tasklist /FI "PID eq …"
. Since this executable will always exit with code0
we instead have to inspect its output. Symfony Process will start any processes under Windows as acmd.exe
subprocess. As suchtasklist /FI "PID eq …"
will then have an output like this for the given process ID (with an English locale):In case the PID is not found, the output will look like this:
Thus this PR assumes that as long as
cmd.exe
is in the output, the process with the given process ID is still actually running.