Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group the help thread commands #532

Closed
Taz03 opened this issue Aug 25, 2022 · 4 comments · Fixed by #574
Closed

Group the help thread commands #532

Taz03 opened this issue Aug 25, 2022 · 4 comments · Fixed by #574
Assignees
Labels
enhance command Modify or improve an existing command or group of commands of the bot priority: normal

Comments

@Taz03
Copy link
Member

Taz03 commented Aug 25, 2022

Group the help thread commands

by using sub slash commands and slash command groups

/help-thread change title
/help-thread change category
/help-thread close
/help-thread pin-message
...

Advantages:-

  1. It is clear that these commands are help-thread commands and will only be used there
  2. Easy to maintain (e.g. only one command to set to help threads in discord integration settings)
@Taz03 Taz03 added enhancement New feature or request enhance command Modify or improve an existing command or group of commands of the bot labels Aug 25, 2022
@Zabuzard
Copy link
Member

When creating the commands initially, I thought about that as well. But then thought its easier for the user if the command starts with the actual word they want to use. I.e. /change....

At that point there was only one command though /change-help-category and not 2 or 3.

I am still unsure though. The commands should be as simple to use as possible. So priority is on the UX and not on how nice they are to maintain in code. For 1., id like to note that the commands are already only visible in help threads, since Discord allows to set that in the integration settings.

All in all I am unsure about this. Other opinions?

@Zabuzard Zabuzard added priority: normal and removed enhancement New feature or request labels Aug 25, 2022
@Taz03
Copy link
Member Author

Taz03 commented Aug 25, 2022

When creating the commands initially, I thought about that as well. But then thought its easier for the user if the command starts with the actual word they want to use. I.e. /change....

I mean they can still get the command pop up when they do that for example this tag manage command with a create sub command will pop up when i only write create
image

@Taz03 Taz03 added the good first issue Good for newcomers label Aug 25, 2022
@Zabuzard
Copy link
Member

Fair. Sounds good to me.

@Zabuzard
Copy link
Member

@Taz03 Since you tagged it good first issue, please outline in the description which files to touch, what to do and where one can find examples.

Just because something is simple, doesnt mean its directly beginner friendly. Gotta give some outline and help.

@Taz03 Taz03 removed the good first issue Good for newcomers label Aug 26, 2022
@Taz03 Taz03 self-assigned this Sep 16, 2022
@Taz03 Taz03 closed this as completed in #574 Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance command Modify or improve an existing command or group of commands of the bot priority: normal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants