Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grouped help thread commands #574

Merged
merged 11 commits into from Oct 4, 2022
Merged

Grouped help thread commands #574

merged 11 commits into from Oct 4, 2022

Conversation

Taz03
Copy link
Member

@Taz03 Taz03 commented Sep 18, 2022 •
edited

closes #532
more info on the issue

@Taz03 Taz03 requested review from a team as code owners September 18, 2022 11:15
@Taz03 Taz03 self-assigned this Sep 18, 2022
@Taz03 Taz03 added enhance command Modify or improve an existing command or group of commands of the bot priority: normal labels Sep 18, 2022
Zabuzard
Zabuzard requested changes Sep 19, 2022
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They shouldnt be merged into a single class. Prefer doing it like TagManageCommand which has them still all separated

@Taz03
Copy link
Member Author

Taz03 commented Sep 20, 2022

They shouldnt be merged into a single class. Prefer doing it like TagManageCommand which has them still all separated

isn't that is in a single class too?

@Zabuzard
Copy link
Member

They shouldnt be merged into a single class. Prefer doing it like TagManageCommand which has them still all separated

isn't that is in a single class too?

Oh. Right. Ill doublecheck.

@Taz03 Taz03 requested review from Zabuzard and a team September 21, 2022 09:47
@Taz03 Taz03 linked an issue Sep 23, 2022 that may be closed by this pull request
Bookmark question thread command #570
Closed
Zabuzard
Zabuzard requested changes Sep 23, 2022
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this BOOKMARK stuff? Please do not add stuff from a different PR/issue to this

@Taz03
Copy link
Member Author

Taz03 commented Sep 23, 2022

What is this BOOKMARK stuff? Please do not add stuff from a different PR/issue to this

ok 😟

@Zabuzard
Copy link
Member

What is this BOOKMARK stuff? Please do not add stuff from a different PR/issue to this

ok 😟

Sorry, but its better to have things separated. U can branch off this branch for the other PR, if u want to not have to wait.

@Taz03 Taz03 removed a link to an issue Sep 24, 2022
Bookmark question thread command #570
Closed
@Zabuzard Zabuzard self-assigned this Sep 28, 2022
Zabuzard
Zabuzard previously approved these changes Sep 28, 2022
View reviewed changes
@Taz03
Copy link
Member Author

Taz03 commented Sep 28, 2022

wow u changed a lot, looking nice

Zabuzard
Zabuzard previously approved these changes Sep 30, 2022
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Taz03 Taz03 merged commit c54df4a into develop Oct 4, 2022
@Taz03 Taz03 deleted the group-help-commands branch October 4, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

@Tais993 Tais993 Tais993 approved these changes

Assignees

@Zabuzard Zabuzard

@Taz03 Taz03

Labels
enhance command Modify or improve an existing command or group of commands of the bot priority: normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group the help thread commands
3 participants
@Taz03 @Zabuzard @Tais993