Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified discriminator #1050

Merged

Conversation

vishv843
Copy link
Contributor

@vishv843 vishv843 commented Mar 11, 2024

image
This commit will change the displayed name as shown in the image

resolves #867

@vishv843 vishv843 requested a review from a team as a code owner March 11, 2024 04:13
@CLAassistant
Copy link

CLAassistant commented Mar 11, 2024

CLA assistant check
All committers have signed the CLA.

@vishv843 vishv843 mentioned this pull request Mar 11, 2024
5 tasks
Copy link
Member

@ankitsmt211 ankitsmt211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍
welcome to the project 😊

@ankitsmt211
Copy link
Member

when this is merged, #1002 also needs to be closed.

Copy link
Member

@christolis christolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankitsmt211 ankitsmt211 merged commit 206f71c into Together-Java:develop Mar 11, 2024
9 checks passed
Taz03 pushed a commit that referenced this pull request Mar 13, 2024
refactor username to be displayed for gists
@ankitsmt211 ankitsmt211 mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong discriminator shown for users with new username system
5 participants