New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

加入注解指定http配置 #50

Open

tangtj1 wants to merge 2 commits into TogetherOS:master from tangtj1:master

tangtj1 commented Mar 8, 2020

加入@CicadaRoute Http Method 配置

使用url+http method组合为映射键

未配置默认支持POST,GET,PUT,PATCH,DELETED
url+http method 组合映射的java方法不可重复

tangtj added 2 commits

March 8, 2020 16:54


          Route annotation configuration specified Http method support

4def12a


          add example

f4307bb

crossoverJie added the enhancement label

Member

crossoverJie commented Mar 8, 2020

不好意思，这类大的 features 通常很难 merge，原因有以下几点：

可能设计实现思路与项目本身不符。
代码太多，很难 review 及测试。

所以通常这类新的 features 一般都是 fork 之后自己维护，或者和作者沟通后今后再实现这一 features 时可以探讨和参考。

如果是一个组织的成员，大家一般都会在线下(私下沟通)达成一致之后再做开发和 PR.

基于以上几点建议大家对开源项目的 pr 可以是对 bug 的修复，或者是小部分可控代码的优化，或者分批提交，不然作者很难控制整个项目的“风格”及“方向”。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment