Update Toggles to not throw incorrectParameterSize error when decrypting empty strings #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing empty strings Update Toggles to not throw incorrectParameterSize error when decrypting empty strings
victor-sarda
approved these changes
Nov 23, 2023
| @@ -42,6 +44,11 @@ extension ToggleManager { | |||
| guard let cipherConfiguration = cipherConfiguration else { | |||
| throw FetchError.missingCipherConfiguration | |||
| } | |||
|
|
|||
| if value == "" && cipherConfiguration.ignoreEmptyStrings { | |||
There was a problem hiding this comment.
Suggested change
| if value == "" && cipherConfiguration.ignoreEmptyStrings { | |
| if value.isEmpty && cipherConfiguration.ignoreEmptyStrings { |
albertodebortoli
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Toggles to not throw incorrectParameterSize error when decrypting empty strings
I have gone with a statement to check for an empty string rather than catch the incorrectParameterSize error.
This is so only the case where "" is passed in will be ignored (if the option is selected in the CipherConfiguration)
If the incorrectParameterSize error is thrown for any other reason it will still be raised.