Remove LOGGER_ERROR for harmless send failure. #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zoff99
previously requested changes
Jul 15, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained
toxcore/net_crypto.c, line 1177 at r1 (raw file):
LOGGER_DEBUG(c->log, "send_data_packet failed");
can we make it:
LOGGER_DEBUG(c->log, "send_data_packet failed, maximum speed reached");
iphydf
changed the title
iphydf
approved these changes
Jul 17, 2018
complete! 1 of 1 LGTMs obtained
…in send_lossless_packet()
iphydf
force-pushed
the
sendDataFailLogging
branch
from
8bae40b
to
7c05b3a
Compare
iphydf
dismissed
zoff99’s stale review
We can make that change, but it doesn't need to block this PR now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change LOGGER_ERROR to LOGGER_DEBUG for failed packet send in
send_lossless_packet(), since the packet is added to the send queue anyway.
This change is