Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation notice to some UPPER_CASE enums. #1036

Merged
merged 1 commit into from Aug 12, 2018
Merged

Add deprecation notice to some UPPER_CASE enums. #1036

merged 1 commit into from Aug 12, 2018

Commits on Aug 11, 2018

  1. Add deprecation notice to some UPPER_CASE enums. 

    The enumerators won't change, but the type name will change in 0.3.0.
Reasoning:
- Type names in toxcore start with an uppercase letter and either have at
  least one lowercase letter in them, or are less than 4 characters long.
- Constants consist of 4 or more uppercase letters or underscores.

By these rules, "DHT" is a type name, but "TOX_USER_STATUS" is a
constant. We provide Tox_User_Status as an alternative for now, and will
switch to that in 0.3.0, removing the UPPER_CASE versions.
    @iphydf
    iphydf committed Aug 11, 2018
    Copy the full SHA
    503d9f7 View commit details
    Browse the repository at this point in the history