Add TCP support to DHT-based group chats. #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
iphydf
added
the
enhancement
iphydf
force-pushed
the
tcp-dht-group-chats
branch
from
3c48390
to
377094c
Compare
JFreegman
force-pushed
the
tcp-dht-group-chats
branch
2 times, most recently
from
8921dae
to
a4342f8
Compare
iphydf
force-pushed
the
tcp-dht-group-chats
branch
from
a4342f8
to
ca3e20b
Compare
JFreegman
force-pushed
the
tcp-dht-group-chats
branch
6 times, most recently
from
0080d6c
to
60efab9
Compare
not tested yet, breaks api
This removes some duplicate code
iphydf
force-pushed
the
tcp-dht-group-chats
branch
2 times, most recently
from
d03bc75
to
cd0250c
Compare
Separate m_add_contact_no_request into two functions and remove some redundant public key checks that always evaluate to false
iphydf
force-pushed
the
tcp-dht-group-chats
branch
from
cd0250c
to
bed8b99
Compare
iphydf
force-pushed
the
tcp-dht-group-chats
branch
from
68b3702
to
e86d6c6
Compare
Codecov Report
@@ Coverage Diff @@
## udp-dht-group-chats #1448 +/- ##
====================================================
Coverage 79.10% 79.10%
====================================================
Files 94 94
Lines 20082 20082
====================================================
Hits 15886 15886
Misses 4196 4196 Continue to review full report at Codecov.
|
JFreegman
force-pushed
the
tcp-dht-group-chats
branch
4 times, most recently
from
f044dca
to
2914efb
Compare
JFreegman
force-pushed
the
tcp-dht-group-chats
branch
from
2914efb
to
67fbd31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is