Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UB comment r/t deleting a friend w/ active call #148

Merged
merged 1 commit into from Sep 19, 2016

Conversation

GrayHatter
Copy link

@GrayHatter GrayHatter commented Sep 19, 2016

This change is Reviewable

@GrayHatter
Copy link
Author

closes #147

@JFreegman
Copy link
Member

toxcore/Messenger.c, line 417 at r1 (raw file):

    if (m->friend_connectionstatuschange_internal) {
        // This is a direct callback to tell ToxAV that the friend has disconnected.
        // The userdata in this callback is set to NULL. Which if there is an active

Weird fragmented sentence. Should say something like: "The userdata in this callback is set to NULL, which will get passed back to the user if there is an active call. This behavior is expected..."


Comments from Reviewable

@JFreegman
Copy link
Member

:lgtm_strong:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@GrayHatter
Copy link
Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.


toxcore/Messenger.c, line 417 at r1 (raw file):

Previously, JFreegman wrote…

Weird fragmented sentence. Should say something like: "The userdata in this callback is set to NULL, which will get passed back to the user if there is an active call. This behavior is expected..."

Done.

Comments from Reviewable

@iphydf iphydf merged commit d497bfe into TokTok:master Sep 19, 2016
@iphydf iphydf added this to the v0.0.1 milestone Nov 5, 2016
@GrayHatter GrayHatter deleted the comments branch November 19, 2016 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants