chore: Cygwin build

[redmanmale]

Based on Windows docker scripts with some tweaks:

• add parameter CROSS_COMPILE for switching between Cygwin and Docker:
  • true for Docker
  • false for Cygwin
• disable set -e -x because some dependencies builds fail due to that
• remove prefix and tmp folders to run a clean build each time
• build Opus from tarball not from git clone because autogen.sh failed on Cygwin due to some error with ltmain.sh symlink:

  Updating build configuration files, please wait....
  libtoolize: putting auxiliary files in '.'.
  libtoolize: linking file './ltmain.sh'
  autoreconf-2.69: libtoolize failed with exit status: 1

• add -fstack-protector to CMAKE_EXE_LINKER_FLAGS and -lssp when creating libtox.dll to fix (Something broke - undefined reference to `__memcpy_chk' msys2/MINGW-packages#5868)
• change libwinpthread.a folder for libtox.dll
• disable chmod

---

This change is 

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ redmanmale
❌ nurupo
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[codecov]

Codecov Report

Merging #1537 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1537      +/-   ##
==========================================
- Coverage   84.17%   84.08%   -0.09%     
==========================================
  Files          87       87              
  Lines       16245    16245              
==========================================
- Hits        13674    13660      -14     
- Misses       2571     2585      +14     

Impacted Files	Coverage Δ
auto_tests/toxav_many_test.c	93.20% <0.00%> (-3.71%)	⬇️
auto_tests/toxav_basic_test.c	83.93% <0.00%> (-1.61%)	⬇️
toxcore/friend_connection.c	94.03% <0.00%> (-1.14%)	⬇️
toxcore/LAN_discovery.c	85.84% <0.00%> (-0.95%)	⬇️
toxcore/onion_client.c	95.78% <0.00%> (-0.61%)	⬇️
toxcore/net_crypto.c	94.41% <0.00%> (-0.10%)	⬇️
toxav/groupav.c	82.99% <0.00%> (+1.21%)	⬆️
toxcore/crypto_core_test.cc	100.00% <0.00%> (+10.71%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56992b0...e8629ae. Read the comment docs.

[nurupo]

Please don't disable set -e -x. It's purpose is exactly what you are observing - fail the whole compilation process if any of individual commands fail. Without it you can have silent failures that can affect the build with the build seemingly succeeding. Instead, identify the commands that fail, try to make so that they don't fail, and if not possible, add || true to them.

[redmanmale]

Please don't disable set -e -x. It's purpose is exactly what you are observing - fail the whole compilation process if any of individual commands fail. Without it you can have silent failures that can affect the build with the build seemingly succeeding. Instead, identify the commands that fail, try to make so that they don't fail, and if not possible, add || true to them.

I understand its purpose but for some reason with them some deps builds (autogen or configure) just fail. How could it be work around with || true?

Could get logs.

[redmanmale]

I'd like to try one more thing.

[redmanmale]

Finally get libtox.dll working.

[redmanmale]

Just wanted to re-run circleci tests but they failed again.

[redmanmale]

@nurupo what I need to do to get this merged?

[nurupo]

I'm working on getting this up-to-date locally, will push when I fix some things.

[nurupo]

Looks like I can't push into redmanmale's PR branch.

@redmanmale could you pull from redmanmale-cygwin-build branch of https://github.com/nurupo/InsertProjectNameHere?

I have rebased your PR on master, then fixed a couple of things, squashed all of these commits together and then added a commit updating Windows build deps. So it's just two commits in total now: adding Cygwin support and updating deps.

[redmanmale]

In your last commit (nurupo@3dec63a) you've undone the whole cross-compile stuff...

[nurupo]

Because those if-s are no longer needed after I have updated the deps and Debian version in Docker. I have tested it and it cross-compiles without these things now. Please check if it still compiles in Cygwin, I don't have a Windows install handy to test that.

whole

Not whole, there is still at least one $CROSS_COMPILE somewhere in there, those that I have left in should still be needed.

[redmanmale]

@nurupo
Done.
I've fixed couple of things (c1be30c) and checked that it works on Cygwin.

[nurupo]

Updated commits with yours and Restyled's fixes in the redmanmale-cygwin-build branch of https://github.com/nurupo/InsertProjectNameHere.

The only thing I didn't fix is putting quotes around $CURL_OPTIONS, as that would break the curl invocation. It's a false positive from Restyle/shellharden.

[nurupo]

Oh, I didn't notice that the Codacy check is failing too due to INSTALL.md formatting. Let me fix that...

[nurupo]

Fixed and pushed.

[nurupo]

Alright, looks good to me. This is ready to get merged.

@iphydf @robinlinden ping ping ping. Can you get this merged? GitHub won't let me due to the checks:

$ git push origin master 
warning: not sending a push certificate since the receiving end does not support --signed push
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: 4 of 13 required status checks have not succeeded: 1 expected, 1 failing, and 2 pending.
To github.com:TokTok/c-toxcore.git
 ! [remote rejected]   master -> master (protected branch hook declined)
error: failed to push some refs to 'github.com:TokTok/c-toxcore.git'

Regarding the failed checks:

• Codacy can't make up its mind about adding or removing 2 spaces before the list bullets, so I give up on it. Even now it suggests adding 2 spaces for some lines and removing 2 spaces for other, when it's supposed to be a single level list, there are no sub-lists in there...

• restyled's fixes (Codacy complains about those too) of quoting variables containing multiple arguments to cmake andcurl make those multiple arguments being passed as one, breaking those command invocations, so restyled should be ignored. However, it's a required check and I lack any permissions required to bypass it.