Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make group announcements work without TCP requirement #1570

Merged
merged 1 commit into from May 15, 2020

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented May 15, 2020

This change is Reviewable

@JFreegman JFreegman added this to the groupchats milestone May 15, 2020
@auto-add-label auto-add-label bot added the bug Bug fix for the user, not a fix to a build script label May 15, 2020
@JFreegman JFreegman force-pushed the ngc_no_tcp branch 4 times, most recently from 6a171c0 to bc88a2d Compare May 15, 2020 19:50
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #1570 into ngc will increase coverage by 0.46%.
The diff coverage is 44.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##              ngc    #1570      +/-   ##
==========================================
+ Coverage   80.83%   81.29%   +0.46%     
==========================================
  Files          95       95              
  Lines       20515    20524       +9     
==========================================
+ Hits        16583    16685     +102     
+ Misses       3932     3839      -93     
Impacted Files Coverage Δ
toxcore/group_chats.c 67.99% <31.14%> (+2.71%) ⬆️
toxcore/Messenger.c 86.13% <77.27%> (-0.08%) ⬇️
toxcore/group_announce.c 92.02% <100.00%> (-0.12%) ⬇️
toxav/bwcontroller.c 42.10% <0.00%> (-7.90%) ⬇️
toxcore/net_crypto.c 94.23% <0.00%> (-0.37%) ⬇️
toxav/toxav.c 69.09% <0.00%> (-0.23%) ⬇️
toxcore/TCP_connection.c 76.75% <0.00%> (+0.18%) ⬆️
toxcore/friend_connection.c 95.53% <0.00%> (+1.11%) ⬆️
auto_tests/toxav_basic_test.c 85.54% <0.00%> (+1.60%) ⬆️
toxcore/TCP_client.c 64.76% <0.00%> (+2.59%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e3a79f...da8808d. Read the comment docs.

@JFreegman JFreegman merged commit da8808d into TokTok:ngc May 15, 2020
@JFreegman JFreegman deleted the ngc_no_tcp branch May 16, 2020 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix for the user, not a fix to a build script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant