Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve self group announcement mechanism #1581

Merged
merged 1 commit into from May 17, 2020

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented May 17, 2020

Self announcements are now refreshed when either our TCP or UDP connection changes
as long as one or the other is connected. We no longer spam the DHT needlessly
when our TCP status updates. In addition, we always attempt to refresh
our announcements every 10 minutes if possible.


This change is Reviewable

@JFreegman JFreegman added this to the groupchats milestone May 17, 2020
@auto-add-label auto-add-label bot added the refactor Refactoring production code, eg. renaming a variable, not affecting semantics label May 17, 2020
Self announcements are now refreshed when either our TCP or UDP connection changes
as long as one or the other is connected. We no longer spam the DHT needlessly
when our TCP status updates. In addition, we always attempt to refresh
our announcements every 10 minutes if possible.
@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #1581 into ngc will decrease coverage by 0.13%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              ngc    #1581      +/-   ##
==========================================
- Coverage   81.35%   81.21%   -0.14%     
==========================================
  Files          95       95              
  Lines       20507    20528      +21     
==========================================
- Hits        16683    16672      -11     
- Misses       3824     3856      +32     
Impacted Files Coverage Δ
toxcore/group_chats.c 67.95% <53.33%> (-1.54%) ⬇️
toxcore/Messenger.c 86.21% <83.33%> (+0.15%) ⬆️
toxcore/crypto_core_test.cc 89.28% <0.00%> (-10.72%) ⬇️
toxav/groupav.c 81.78% <0.00%> (-1.22%) ⬇️
toxcore/LAN_discovery.c 83.65% <0.00%> (-0.97%) ⬇️
auto_tests/group_state_test.c 98.26% <0.00%> (-0.87%) ⬇️
toxcore/onion_client.c 96.42% <0.00%> (+0.57%) ⬆️
toxcore/net_crypto.c 94.50% <0.00%> (+0.73%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b31d3...d25bdd7. Read the comment docs.

@JFreegman JFreegman merged commit d25bdd7 into TokTok:ngc May 17, 2020
@JFreegman JFreegman deleted the ngc_self_announce branch August 11, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring production code, eg. renaming a variable, not affecting semantics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant