Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove a bunch of useless group code from Messenger.c #1604

Merged
merged 1 commit into from May 21, 2020

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented May 21, 2020

Everything the Messenger Group struct held is now taken care of by the
GC_Chat instance


This change is Reviewable

@JFreegman JFreegman added this to the groupchats milestone May 21, 2020
@JFreegman JFreegman changed the title Remove a bunch of useless group code from Messenger.c refactor: Remove a bunch of useless group code from Messenger.c May 21, 2020
@auto-add-label auto-add-label bot added the refactor Refactoring production code, eg. renaming a variable, not affecting semantics label May 21, 2020
@ghost
Copy link

ghost commented May 21, 2020

DeepCode's analysis on #e42604 found:

⚠️ 1 warning 1 minor issue.

👉 View analysis in DeepCode’s Dashboard

☺️ If you want to provide feedback on our bot, here is how to contact us.

Everything the Messenger Group struct held is now taken care of by the
GC_Chat instance
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #1604 into ngc will decrease coverage by 0.02%.
The diff coverage is 67.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##              ngc    #1604      +/-   ##
==========================================
- Coverage   81.38%   81.35%   -0.03%     
==========================================
  Files          95       95              
  Lines       20410    20351      -59     
==========================================
- Hits        16611    16557      -54     
+ Misses       3799     3794       -5     
Impacted Files Coverage Δ
toxcore/group_chats.c 68.54% <35.71%> (-0.32%) ⬇️
toxcore/Messenger.c 86.02% <94.11%> (-0.33%) ⬇️
toxcore/friend_connection.c 94.13% <0.00%> (-0.28%) ⬇️
toxcore/net_crypto.c 93.58% <0.00%> (-0.19%) ⬇️
toxcore/onion_client.c 96.42% <0.00%> (+0.57%) ⬆️
toxcore/group_moderation.c 75.67% <0.00%> (+1.01%) ⬆️
toxav/groupav.c 82.99% <0.00%> (+1.21%) ⬆️
toxcore/friend_requests.c 97.77% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update facf274...e426047. Read the comment docs.

@JFreegman JFreegman merged commit e426047 into TokTok:ngc May 21, 2020
@JFreegman JFreegman deleted the ngc_useless_code branch August 11, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring production code, eg. renaming a variable, not affecting semantics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant