Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add self_disconnected exit type #1606

Merged
merged 1 commit into from May 21, 2020
Merged

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented May 21, 2020

This is mainly so that clients can prevent peer exit spam messages
when they disconnect from all peers at once


This change is Reviewable

@JFreegman JFreegman added this to the groupchats milestone May 21, 2020
@ghost
Copy link

ghost commented May 21, 2020

DeepCode's analysis on #15a7a4 found:

⚠️ 1 warning 1 minor issue.

👉 View analysis in DeepCode’s Dashboard

☺️ If you want to provide feedback on our bot, here is how to contact us.

@JFreegman JFreegman changed the title Add self_disconnected exit type feat: Add self_disconnected exit type May 21, 2020
@auto-add-label auto-add-label bot added the enhancement New feature for the user, not a new feature for build script label May 21, 2020
This is mainly so that clients can prevent peer exit spam messages
when they disconnect from all peers at once
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #1606 into ngc will increase coverage by 0.11%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              ngc    #1606      +/-   ##
==========================================
+ Coverage   81.34%   81.45%   +0.11%     
==========================================
  Files          95       95              
  Lines       20356    20356              
==========================================
+ Hits        16558    16581      +23     
+ Misses       3798     3775      -23     
Impacted Files Coverage Δ
toxcore/group_chats.c 68.79% <50.00%> (-0.05%) ⬇️
toxcore/Messenger.c 86.24% <100.00%> (+0.22%) ⬆️
toxav/bwcontroller.c 42.10% <0.00%> (-7.90%) ⬇️
toxcore/TCP_connection.c 80.26% <0.00%> (-0.38%) ⬇️
toxcore/group.c 91.82% <0.00%> (-0.16%) ⬇️
toxcore/net_crypto.c 94.41% <0.00%> (+0.73%) ⬆️
toxcore/friend_connection.c 95.53% <0.00%> (+1.11%) ⬆️
toxcore/TCP_server.c 82.80% <0.00%> (+2.76%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77aaf10...15a7a48. Read the comment docs.

@JFreegman JFreegman merged commit 15a7a48 into TokTok:ngc May 21, 2020
@JFreegman JFreegman deleted the ngc_disconnect branch May 21, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature for the user, not a new feature for build script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant