msgV3 PoC #1781
Draft
msgV3 PoC #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nurupo
reviewed
Jan 1, 2022
| ``` | ||
| #define TOX_MAX_MESSAGE_LENGTH (1372) | ||
| #define TOX_MSGV3_MSGID_LENGTH (32) | ||
| #define TOX_MSGV3_TIMESTAMP_LENGTH (4) |
There was a problem hiding this comment.
There was a problem hiding this comment.
i know. but whats the fix? using 64bits is taking 8 bytes.
is there a better solution that 64bits?
There was a problem hiding this comment.
Unsigned 32-bits should work until year 2106.
If extended to 5 bytes = 40bits, it could store a range of about 34865 years.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is