Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate tests: split tests part 2. #193

Merged
merged 1 commit into from Oct 15, 2016
Merged

Remove duplicate tests: split tests part 2. #193

merged 1 commit into from Oct 15, 2016

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Oct 11, 2016

No description provided.

GrayHatter
GrayHatter approved these changes Oct 11, 2016
View reviewed changes
Copy link

@GrayHatter GrayHatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think it may be better to rename tox_test to something more accurate, but I wouldn't waste the commit/rebase time.

mannol
mannol approved these changes Oct 15, 2016
View reviewed changes
Copy link

@mannol mannol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like that these tests are finally cleaned up!

@iphydf iphydf merged commit 6d0c806 into TokTok:master Oct 15, 2016
@iphydf iphydf deleted the dedupe-tests branch October 15, 2016 12:57
@iphydf iphydf added this to the v0.0.3 milestone Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrayHatter GrayHatter GrayHatter approved these changes

@mannol mannol mannol approved these changes

Assignees

@GrayHatter GrayHatter

@nurupo nurupo

@mannol mannol

Labels
None yet
Projects
None yet
Milestone
v0.0.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iphydf @GrayHatter @mannol @nurupo