3. Travis astyle

[iphydf]

Depends on #16

---

This change is

[nurupo]

Define "depends". Is it based on #16's branch, instead of master?

[nurupo]

I see, I guess you meant "replaces".

[iphydf]

I meant depends as in "is based on", but then I decided to drop the old one instead.

[nurupo]

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

other/travis/toxcore-script, line 9 [r1] (raw file):

../apidsl/_build/apigen.native other/apidsl/toxav.in.h | $ASTYLE --options=other/astyle/astylerc > toxav/toxav.h
# Check if the code is formatted according to the astyle configuration.
$ASTYLE --options=other/astyle/astylerc tox*/*.[ch]

Just tox*/*.[ch]? There are, at very least, also other/*.[ch] and other/bootstrap_daemon/src/*.[ch].

---

Comments from Reviewable

[nurupo]

Although it's out of scope of this PR, I just want to remind that there was a discussion about changing tox*_version_is_compatible() functions to use a macro, which might be an idea for a next PR someone makes.

---

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[iphydf]

Review status: 9 of 14 files reviewed at latest revision, 1 unresolved discussion.

---

other/travis/toxcore-script, line 9 [r1] (raw file):

Previously, nurupo wrote…

Just tox*/*.[ch]? There are, at very least, also other/*.[ch] and other/bootstrap_daemon/src/*.[ch].

I wanted to avoid a complex expression, but I've changed my mind. It's better we format everything we can.

---

Comments from Reviewable

[iphydf]

It is indeed out of scope. This comment will get lost. You could instead open a ticket to keep track of the discussion.

---

Review status: 9 of 14 files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[iphydf]

@nurupo is this one good to go now?

[GrayHatter]

LGTM

---

Reviewed 7 of 10 files at r1, 5 of 6 files at r2, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

Comments from Reviewable

[GrayHatter]

---

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

Comments from Reviewable

[GrayHatter]

---

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable