refactor: Always fail hard on allocation failure in tox_events. #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-add-label
bot
added
the
refactor
iphydf
force-pushed
the
always-fail-hard
branch
2 times, most recently
from
600ae22
to
fb2c94b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2264 +/- ##
==========================================
+ Coverage 78.92% 78.93% +0.01%
==========================================
Files 127 127
Lines 24063 24001 -62
==========================================
- Hits 18992 18946 -46
+ Misses 5071 5055 -16
Continue to review full report at Codecov.
|
iphydf
force-pushed
the
always-fail-hard
branch
from
fb2c94b
to
f2bb086
Compare
Partial success is not much more helpful, because at the point of allocation failure, the client will probably need to shut down or drop caches to free memory and request re-sends from friends. Those requests don't exist in current Tox messages, but future history-sync based messaging would be able to handle temporary allocation failures. Also in the future, a single iteration will have a limited number of events it can process at a time, configurable through Tox_Options. This way there is an upper limit on how much memory an events iteration can allocate. This will be necessary for security (avoiding Resource Exhaustion Attacks, which the current events system is somewhat vulnerable to).
iphydf
force-pushed
the
always-fail-hard
branch
from
f2bb086
to
af2517b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial success is not much more helpful, because at the point of
allocation failure, the client will probably need to shut down or drop
caches to free memory and request re-sends from friends. Those requests
don't exist in current Tox messages, but future history-sync based
messaging would be able to handle temporary allocation failures.
Also in the future, a single iteration will have a limited number of
events it can process at a time, configurable through Tox_Options. This
way there is an upper limit on how much memory an events iteration can
allocate. This will be necessary for security (avoiding Resource
Exhaustion Attacks, which the current events system is somewhat
vulnerable to).
This change is