refactor: Make some improvements to how often/when we announce a group #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
added
the
refactor
JFreegman
force-pushed
the
ngc_announce_fix
branch
2 times, most recently
from
8b56a49
to
1585048
Compare
sudden6
reviewed
Nov 12, 2022
JFreegman
force-pushed
the
ngc_announce_fix
branch
from
1585048
to
f5c1120
Compare
sudden6
approved these changes
Nov 12, 2022
JFreegman
force-pushed
the
ngc_announce_fix
branch
9 times, most recently
from
b674660
to
a8b0516
Compare
Instead of announcing a group whenever our connection status changes, including when we gain or lose a TCP relay connection, we now only when our UDP status changes, or if our previously announced relay has gone offline. We also refresh our announcement 20 minutes regardless of any connection changes. change should vastly reduce the amount of unnecessary DHT traffic related to group announcements.
JFreegman
force-pushed
the
ngc_announce_fix
branch
from
a8b0516
to
7ee7720
Compare
Codecov Report
@@ Coverage Diff @@
## master #2348 +/- ##
==========================================
- Coverage 78.13% 78.08% -0.05%
==========================================
Files 141 141
Lines 31108 31114 +6
==========================================
- Hits 24306 24296 -10
- Misses 6802 6818 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of announcing a group whenever our connection status changes, including when we gain or lose a TCP relay connection, we now only announce when our UDP status changes, or if our previously announced TCP relay has gone offline. We also refresh our announcement every 20 minutes regardless of any connection changes (this is to rotate the TCP relay in case the chosen one is somehow broken).
This change should vastly reduce the amount of unnecessary DHT traffic related to group announcements.
This change is