fix: resolve_bootstrap_node() not checking net_getipport() returned count correctly #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Green-Sky
force-pushed
the
fix_dns_count_0
branch
from
3b0f7ec
to
8b02033
Compare
Codecov Report
@@ Coverage Diff @@
## master #2361 +/- ##
==========================================
- Coverage 78.10% 9.95% -68.16%
==========================================
Files 141 141
Lines 31114 32503 +1389
==========================================
- Hits 24302 3236 -21066
- Misses 6812 29267 +22455
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I checked the function and its documentation, which are quite confusing and probably led to this error. Can you improve the documentation so that it's more clear in which cases it returns |
Green-Sky
force-pushed
the
fix_dns_count_0
branch
from
8b02033
to
bc195b3
Compare
…ount correctly doc: improve inline docu of return of net_getipport
Green-Sky
force-pushed
the
fix_dns_count_0
branch
from
bc195b3
to
88ffd1a
Compare
|
@sudden6 i specified the return values in the inline docu |
sudden6
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2358
potential security issue, if the DNS server can cause this.
This change is