Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: potential endless loop under extremely high load #2364

Merged
merged 6 commits into from
Dec 8, 2022

Conversation

sudden6
Copy link

@sudden6 sudden6 commented Dec 4, 2022

If there are more connections waiting to be accepted than MAX_INCOMING_CONNECTIONS existing accepted connections are overwritten.


This change is Reviewable

@sudden6 sudden6 added this to the v0.2.19 milestone Dec 4, 2022
@sudden6 sudden6 force-pushed the fix_endless_loop branch 6 times, most recently from 288601d to 701f4e9 Compare December 4, 2022 22:46
If there are more connections waiting to be accepted than
MAX_INCOMING_CONNECTIONS existing accepted connections are overwritten.
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #2364 (8738960) into master (9fae455) will decrease coverage by 68.15%.
The diff coverage is 10.00%.

@@            Coverage Diff             @@
##           master   #2364       +/-   ##
==========================================
- Coverage   78.10%   9.95%   -68.16%     
==========================================
  Files         141     141               
  Lines       31114   32503     +1389     
==========================================
- Hits        24302    3236    -21066     
- Misses       6812   29267    +22455     
Impacted Files Coverage Δ
toxcore/TCP_common.c 6.38% <0.00%> (-72.14%) ⬇️
toxcore/TCP_server.c 8.12% <0.00%> (-70.65%) ⬇️
toxcore/tox.c 7.80% <0.00%> (-56.32%) ⬇️
toxcore/crypto_core.c 33.88% <33.33%> (-59.83%) ⬇️
toxav/toxav_old.c 0.00% <0.00%> (-100.00%) ⬇️
auto_tests/file_saving_test.c 0.00% <0.00%> (-100.00%) ⬇️
auto_tests/conference_two_test.c 0.00% <0.00%> (-100.00%) ⬇️
auto_tests/invalid_tcp_proxy_test.c 0.00% <0.00%> (-100.00%) ⬇️
auto_tests/invalid_udp_proxy_test.c 0.00% <0.00%> (-100.00%) ⬇️
auto_tests/group_message_test.c 5.59% <0.00%> (-93.66%) ⬇️
... and 133 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sudden6 sudden6 merged commit 8738960 into TokTok:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants