cleanup: Add dynamically derived array sizes to the API. #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
computed-array-size
branch
4 times, most recently
from
c81a2ba
to
68dbf63
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2525 +/- ##
==========================================
+ Coverage 68.93% 69.02% +0.08%
==========================================
Files 89 89
Lines 27787 27787
==========================================
+ Hits 19156 19180 +24
+ Misses 8631 8607 -24 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
computed-array-size
branch
from
68dbf63
to
2cad84d
Compare
nurupo
requested changes
Jan 5, 2024
iphydf
force-pushed
the
computed-array-size
branch
from
2cad84d
to
efe625a
Compare
|
Ok, will refrain from looking at it for now since it's a draft (didn't notice at first). |
iphydf
force-pushed
the
computed-array-size
branch
from
efe625a
to
1b93d9d
Compare
iphydf
force-pushed
the
computed-array-size
branch
3 times, most recently
from
3677c99
to
174d5b9
Compare
It's ready for review now. |
iphydf
force-pushed
the
computed-array-size
branch
2 times, most recently
from
187726d
to
4d4fe66
Compare
iphydf
force-pushed
the
computed-array-size
branch
from
4d4fe66
to
814c12a
Compare
nurupo
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is