test: Add more unit tests for add_to_list.

[iphydf]

This change is 

[codecov]

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (05ce5c1) 68.97% compared to head (afc38f2) 69.12%.

Files	Patch %	Lines
toxcore/DHT_test.cc	70.53%	33 Missing ⚠️
toxcore/crypto_core_test_util.cc	50.00%	11 Missing ⚠️
toxcore/network_test_util.cc	65.38%	9 Missing ⚠️
toxcore/DHT_test_util.cc	63.63%	4 Missing ⚠️
toxcore/test_util_test.cc	96.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2531      +/-   ##
==========================================
+ Coverage   68.97%   69.12%   +0.14%     
==========================================
  Files          89       96       +7     
  Lines       27784    27983     +199     
==========================================
+ Hits        19164    19343     +179     
- Misses       8620     8640      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nurupo]

toxcore/crypto_core_test_util.cc line 51 at r2 (raw file):

{
    Test_Random *self = static_cast<Test_Random *>(obj);
    return static_cast<uint32_t>(simple_rng(self->seed)) % upper_bound;

Nit: modulo doesn't result in a uniform distribution, it gets skewed. Might not matter for testing though.
C++' random library has random number generators andstd::uniform_int_distribution() too, wonder why they weren't used here.

[iphydf]

Reviewable status: 0 of 1 approvals obtained (waiting on @Green-Sky and @nurupo)

---

toxcore/crypto_core_test_util.cc line 51 at r2 (raw file):

Previously, nurupo wrote…

Nit: modulo doesn't result in a uniform distribution, it gets skewed. Might not matter for testing though.
C++' random library has random number generators andstd::uniform_int_distribution() too, wonder why they weren't used here.

Added a comment. I'll test/benchmark the C++ stdlib stuff later. For now, this is a very simple and fast implementation intended to be exactly that.

[iphydf]

Reviewable status: 0 of 1 approvals obtained (waiting on @Green-Sky and @nurupo)

---

toxcore/crypto_core_test_util.cc line 51 at r2 (raw file):

Previously, iphydf wrote…

Added a comment. I'll test/benchmark the C++ stdlib stuff later. For now, this is a very simple and fast implementation intended to be exactly that.

I guess LCG is the same as I put above. Maybe I'll refactor it tomorrow, or otherwise it'll be done in the next round of refactorings.

[iphydf]

Reviewable status: 0 of 1 approvals obtained (waiting on @Green-Sky and @nurupo)

---

toxcore/crypto_core_test_util.cc line 51 at r2 (raw file):

Previously, iphydf wrote…

I guess LCG is the same as I put above. Maybe I'll refactor it tomorrow, or otherwise it'll be done in the next round of refactorings.

I've decided to use C++ :P. Done.

[nurupo]

Reviewed 2 of 2 files at r8, all commit messages.
Reviewable status: 0 of 1 approvals obtained (waiting on @Green-Sky)

[nurupo]

FYI was just pointing out something I noticed while skimming through the PR, don't plan on seriously reviewing it so don't hold the PR waiting on my review approval.