refactor: Minor refactoring of get_close_nodes functions.#2539
Merged
Conversation
iphydf
marked this pull request as ready for review
January 10, 2024 12:58
iphydf
force-pushed
the
dht-refr
branch
4 times, most recently
from
January 10, 2024 14:06
a0cae71 to
9461c1f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2539 +/- ##
==========================================
- Coverage 68.96% 68.95% -0.02%
==========================================
Files 96 96
Lines 28023 28027 +4
==========================================
- Hits 19327 19325 -2
- Misses 8696 8702 +6 ☔ View full report in Codecov by Sentry. |
Green-Sky
approved these changes
Jan 10, 2024
Avoiding passing down the entire DHT struct pointer to the inner functions makes it possible in the future to write unit tests without having to construct a full DHT object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoiding passing down the entire DHT struct pointer to the inner functions makes it possible in the future to write unit tests without having to construct a full DHT object.
This change is