fix: don't pass garbage data buffer to packet send functions #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
added
the
cleanup
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2541 +/- ##
=======================================
Coverage 68.96% 68.96%
=======================================
Files 96 96
Lines 28022 28023 +1
=======================================
+ Hits 19324 19327 +3
+ Misses 8698 8696 -2 ☔ View full report in Codecov by Sentry. |
JFreegman
force-pushed
the
group_fix_garbage_data
branch
from
091d123
to
d2146b2
Compare
Green-Sky
approved these changes
Jan 10, 2024
This garbage data was never looked at due to passing a zero length along with it, but it's still undesirable.
JFreegman
force-pushed
the
group_fix_garbage_data
branch
from
d2146b2
to
ebc9643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This garbage data was never looked at due to passing a zero length along with it, but it's still undesirable.
This change is