Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add fuzz tests to the coverage run. #2547

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 11, 2024

So we don't need to write so many edge case tests ourselves for things like parsers, which really don't need those manual tests, as long as we can check for some properties like "can output the parsed data and it'll be the same as the input".


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 11, 2024
@iphydf iphydf marked this pull request as ready for review January 11, 2024 15:26
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (df76f5c) 65.74% compared to head (50f1b30) 68.13%.

Files Patch % Lines
toxcore/group_announce_fuzz_test.cc 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2547      +/-   ##
==========================================
+ Coverage   65.74%   68.13%   +2.38%     
==========================================
  Files         110      118       +8     
  Lines       27687    28162     +475     
==========================================
+ Hits        18203    19188     +985     
+ Misses       9484     8974     -510     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

So we don't need to write so many edge case tests ourselves for things
like parsers, which really don't need those manual tests, as long as we
can check for some properties like "can output the parsed data and it'll
be the same as the input".
@iphydf iphydf merged commit 50f1b30 into TokTok:master Jan 12, 2024
54 of 55 checks passed
@iphydf iphydf deleted the fuzz-coverage branch January 12, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants