Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make all the fuzzers work again, and add a test for protodump. #2554

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 12, 2024

fuzz_select_target wasn't selecting anything, so fuzzers using that function either did nothing or would only ever select one of the functions.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 12, 2024
@iphydf iphydf marked this pull request as ready for review January 12, 2024 16:12
@iphydf iphydf force-pushed the fuzz-select branch 2 times, most recently from bdfe504 to 1b3cf25 Compare January 12, 2024 16:16
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 63 lines in your changes are missing coverage. Please review.

Comparison is base (c4e209e) 68.35% compared to head (4cea4f9) 71.34%.

Files Patch % Lines
testing/fuzzing/fuzz_support.cc 44.82% 32 Missing ⚠️
testing/fuzzing/fuzz_support.h 48.27% 30 Missing ⚠️
testing/fuzzing/bootstrap_fuzz_test.cc 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2554      +/-   ##
==========================================
+ Coverage   68.35%   71.34%   +2.99%     
==========================================
  Files         118      120       +2     
  Lines       28165    28393     +228     
==========================================
+ Hits        19252    20257    +1005     
+ Misses       8913     8136     -777     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the fuzz-select branch 5 times, most recently from bb46137 to 08d78af Compare January 12, 2024 17:07
@iphydf iphydf force-pushed the fuzz-select branch 7 times, most recently from 03470a6 to 9755b78 Compare January 13, 2024 11:42
@iphydf iphydf changed the title fix: fuzz_select_target wasn't selecting anything. fix: Make all the fuzzers work again, and add a test for protodump. Jan 13, 2024
@iphydf iphydf force-pushed the fuzz-select branch 2 times, most recently from 3ff979d to 9325a81 Compare January 13, 2024 12:08
fuzz_select_target wasn't selecting anything, so fuzzers using that
function either did nothing or would only ever select one of the
functions.
@iphydf iphydf merged commit 4cea4f9 into TokTok:master Jan 13, 2024
53 of 55 checks passed
@iphydf iphydf deleted the fuzz-select branch January 13, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants