refactor: Migrate auto_tests to new events API. #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
events-tests
branch
20 times, most recently
from
6efb550
to
8015af8
Compare
iphydf
force-pushed
the
events-tests
branch
7 times, most recently
from
c7f4eb6
to
e91ed88
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2559 +/- ##
==========================================
+ Coverage 66.80% 71.83% +5.02%
==========================================
Files 148 148
Lines 30376 30376
==========================================
+ Hits 20294 21820 +1526
+ Misses 10082 8556 -1526 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Green Sky <green@g-s.xyz>
JFreegman
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Reviewed 34 of 35 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @iphydf)
auto_tests/group_general_test.c line 65 at r2 (raw file):
{ for (size_t i = 0; i < tox_count; ++i) { // make sure we got an F response
what's an F response?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is